[libvirt] [PATCH] fix a bug in remoteSerializeTypedParameters

Eric Blake eblake at redhat.com
Wed Nov 16 15:59:31 UTC 2011


On 11/16/2011 01:38 AM, Hu Tao wrote:
> This is a fatal typo believed to be very likely to happen when using
> both i and j at the same time for indexing.

Yep, and thanks for catching it.

> ---
>  daemon/remote.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/daemon/remote.c b/daemon/remote.c
> index 857835e..97c9538 100644
> --- a/daemon/remote.c
> +++ b/daemon/remote.c
> @@ -710,7 +710,7 @@ remoteSerializeTypedParameters(virTypedParameterPtr params,
>              goto cleanup;
>          }
>          val[j].value.type = params[i].type;
> -        switch (params[j].type) {
> +        switch (params[i].type) {

ACK and pushed.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111116/2b379fdf/attachment-0001.sig>


More information about the libvir-list mailing list