[libvirt] [PATCH v3 2/2] Make the API public

[Srivatsa S. Bhat]

On 11/23/2011 06:55 PM, Eric Blake wrote:

> On 11/23/2011 05:33 AM, Srivatsa S. Bhat wrote:
>>> Perhaps, I'll send a companion patch to add the hybrid-suspend discovery
>>> to that, and then base the next version of this patchset on that.
>>>
>>
>> Actually thinking about it, I don't see how that would be useful for a
>> libvirt managed host. The hybrid suspend feature was designed keeping
>> laptops in mind, which when suspended with the power supply turned off
>> (and hence powered by only batteries), the laptops could lose power and
>> power off, and hence in that case resuming the saved contents from disk
>> would be beneficial.
> 
> Whether to use it is a policy decision.  I have much less heartburn
> providing a feature no one will use, but exposing full flexibility, than
> I do with failing to provide a feature on a policy decision ("no one
> will want that") only to find out that someone really did want it.
> 
>>
>> I doubt if anyone would be seriously interested in running virtualization
>> software on laptops and managing them via libvirt, rather than using
>> servers for that purpose (which have continuous power-supply).
> 
> Enterprise VMs, sure.  But personal VMs - I run VMs on my laptop, and
> imagine that I may eventually have a reason to use a hybrid suspend.
> 
>>
>> Though I have already written a patch to add the hybrid-suspend capability
>> discovery to libvirt and export it in the XML along with S3 and S4, I
>> would rather prefer not to send that patch if nobody is going to use it.
> 
> Please go ahead with sending the patch.
> 


OK, I will send the patch. Thanks for the clarification!

Regards,
Srivatsa S. Bhat
IBM Linux Technology Center