[libvirt] [PATCH] virsh: Fix possible deadlock when virsh is about to exit

Peter Krempa pkrempa at redhat.com
Wed Nov 30 23:24:07 UTC 2011


Dňa 30.11.2011 20:42, Jiri Denemark  wrote / napísal(a):
> Not only was ctl->quit accessed without a mutex but unfortunately,
> virEventAddTimeout only interrupts the poll when event loop is running
> so the hack needs to add a timeout that will make next poll return
> immediately without blocking.
> ---
>   tools/virsh.c |   39 +++++++++++++++++++++++++++++++++------
>   1 files changed, 33 insertions(+), 6 deletions(-)
>

This patch fixes it for me. ACK. Without this patch there was 
approximately a 1 in 5 chance that one of the tests would hang. With 
this patch, the test ran for 5 hours in a loop without hanging.

Peter




More information about the libvir-list mailing list