[libvirt] [PATCH 2/7] Fix crash formatting virtio console

Eric Blake eblake at redhat.com
Tue Nov 1 22:58:03 UTC 2011


On 10/20/2011 08:47 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"<berrange at redhat.com>
>
> qemuBuildVirtioSerialPortDevStr was mistakenly accessing the
> target.name field in the virDomainChrDef object for chardevs
> belonging to a console. Those chardevs only have port set,
> and if there's>  1 console, the>  1port number results in
> trying to access a target.name with address 0x1
>
> * src/qemu/qemu_command.c: Fix target.name handling and
>    make code more robust wrt error reporting
>
> * src/qemu/qemu_command.c: Conditionally access target.name
> ---
>   src/qemu/qemu_command.c |   39 +++++++++++++++++++++++++++------------
>   1 files changed, 27 insertions(+), 12 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list