[libvirt] bug: try to take disk snapshot for LVM2 Volume

[Daniel P. Berrange]

On Mon, Nov 07, 2011 at 01:14:12PM +0900, MATSUDA, Daiki wrote:
> Hi, Eric.
> 
> > On 09/29/2011 11:26 PM, MATSUDA, Daiki wrote:
> >> I tried the new snapshot function implemented by Eric Blake.
> >>
> >> It works very well for QCOW2 disk image system.
> >> But I often use LVM2 volume for QEMU virtual machines and tried to take
> >> disk snapshot by virsh command ( snapshot-create DOMNAME --disk-only).
> >> So, finally qemu monitor command 'snapshot_blkdev' accepts the LVM2
> >> volume and create QCOW2 snapshot image. In addition, domain's
> >> configuration file is replaced to use snapshot disk image instead of
> >> LVM2 volume.
> > 
> > It sounds like virsh did what it was told, but that you told it so
> > little information that it had to fill in the gaps and choose its own
> > destination file name (hence the .1317357844 suffix after the action).
> > Your situation sounds like a case where you may want a bit more control
> > over the destination file name.
> 
> I made the patch for the problem to take the snapshot but qcow2. It use
> the 'qemu-img' command, I know that it is not essential solution. But I
> think it is better than to link qemu's libraries.

There is an internal libvirt API for disk formats in src/util/storage_file.h

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|