[libvirt] PATCH: Fix build without MACVTAP

Michael Wood esiotrot at gmail.com
Sat Nov 12 11:39:17 UTC 2011


Hi

Commit c31d23a78715f1144c73862c46ab0436de8b5e85 removed the "conn"
parameter from qemuPhysIfaceConnect(), but it's still used if
WITH_MACVTAP is false.  Also, it's still mentioned in the comment
above the function:

/**
 * qemuPhysIfaceConnect:
 * @def: the definition of the VM (needed by 802.1Qbh and audit)
 * @conn: pointer to virConnect object
 * @driver: pointer to the qemud_driver
 * @net: pointer to he VM's interface description with direct device type
 * @qemuCaps: flags for qemu
 *
 * Returns a filedescriptor on success or -1 in case of error.
 */
int
qemuPhysIfaceConnect(virDomainDefPtr def,
                     struct qemud_driver *driver,
                     virDomainNetDefPtr net,
                     virBitmapPtr qemuCaps,
                     enum virVMOperationType vmop)
{
    int rc;
#if WITH_MACVTAP
[...]
#else
    (void)def;
    (void)conn;
    (void)net;
    (void)qemuCaps;
    (void)driver;
    (void)vmop;
    qemuReportError(VIR_ERR_INTERNAL_ERROR,
                    "%s", _("No support for macvtap device"));
    rc = -1;
#endif
    return rc;
}

-- 
Michael Wood <esiotrot at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-build-without-MACVTAP.patch
Type: text/x-diff
Size: 1053 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111112/41984f3a/attachment-0001.bin>


More information about the libvir-list mailing list