[libvirt] [PATCH 02/16] Rename and split the macvtap.c file

[Laine Stump]

On 11/15/2011 06:14 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"<berrange at redhat.com>
>
> Rename the macvtap.c file to virnetdevmacvlan.c to reflect its
> functionality. Move the port profile association code out into
> virnetdevvportprofile.c. Make the APIs available unconditionally
> to callers

One concern I have after reading this sentence - do you changes have any 
implications for systems that don't have the correct version of libnl, 
and thus cannot have macvtap enabled? (e.g. RHEL5)

Assuming that the answer to the above is "no", and going on faith (and 
the fact that make && make check passed) that the gigantic diff really 
is just moving identical code between files (except for removing the 
#ifdef MACVTAPs in several places) - ACK.

(It might be a useful exercise to build on some system with no 
macvtap|libnl support to make sure nothing blows up).