[libvirt] [PATCH V5 03/10] Make filter creation in root table more flexible
Eric Blake
eblake at redhat.com
Thu Nov 17 22:28:58 UTC 2011
On 11/17/2011 01:11 PM, Stefan Berger wrote:
> Use the previously introduced chain priorities to sort the chains for access
> from an interface's 'root' table and have them created in the proper order.
> This gets rid of a lot of code that was previously creating the chains in a
> more hardcoded way.
>
> To determine what protocol a filter is used for evaluation do prefix-
> matching, i.e., the filter 'arp' is used to filter for the 'arp' protocol,
> 'ipv4' for the 'ipv4' protocol and 'arp-xyz' will also be used to filter
> for the 'arp' protocol following the prefix 'arp' in its name.
>
> Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>
>
> ---
>
> v5:
> - followed Eric Blake's suggestions:
> - return -1 as error code
> - add comments as appropriate
> - other style fixes
>
> ---
> src/nwfilter/nwfilter_ebiptables_driver.c | 134 ++++++++++++++++++++++--------
> 1 file changed, 102 insertions(+), 32 deletions(-)
Looks like you covered my v4 findings.
ACK.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111117/ff8c5775/attachment-0001.sig>
More information about the libvir-list
mailing list