[libvirt] virt-viewer, requirement question

[Jason Helfman]

On Fri, Nov 18, 2011 at 10:03:05AM +0000, Daniel P. Berrange thus spake:
>On Thu, Nov 17, 2011 at 05:24:15PM -0800, Jason Helfman wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA256
>>
>> Hi,
>>
>> I am the port maintainer for libvirt, and associated tools, in the FreeBSD
>> Project.
>>
>> I was wondering if "Require SPICE-GTK >= 0.6.0" for virt-viewer, is
>> accurate, or is this optional.
>
>With the latest virt-viewer release, you can disable either SPICE-GTK
>or GTK-VNC by passing suitable args to ./configure. Obviously if you
>disable them both, the resulting virt-viewer won't be very useful ;-P
>
>
Thanks! And had no idea you either wrote gtk-vnc, or contributed to it,
which leads me to my next question :)

I am in the midst of updating it to a current version, to update
virt-viewer, however I was unable to find the source of this patch that was
in FreeBSD. All the other patches have been incorporated into the code, it
seems.

--- src/gvnc.h.orig	2008-03-24 11:39:20.000000000 -0400
+++ src/gvnc.h	2008-03-24 11:40:22.000000000 -0400
@@ -3,6 +3,19 @@
  
  #include <glib.h>
  #include <stdint.h>
+#ifdef __FreeBSD__
+#include <sys/endian.h>
+
+#define __BYTE_ORDER		_BYTE_ORDER
+#define __LITTLE_ENDIAN		_LITTLE_ENDIAN
+#define __BIG_ENDIAN		_BIG_ENDIAN
+
+#define bswap_16		bswap16
+#define bswap_32		bswap32
+#define bswap_64		bswap64
+#else
+#include <endian.h>
+#endif
  
  struct gvnc;

Thanks!
Jason

-- 
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html
E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5