[libvirt] [PATCH] Don't copy sexpr node value that is an empty string

Eric Blake eblake at redhat.com
Fri Nov 18 22:20:02 UTC 2011


On 11/18/2011 03:16 PM, Jim Fehlig wrote:
> Xen4.1 initializes some unspecified sexpr config items to an empty
> string, unlike previous Xen versions that would leave the item unset.
> E.g. the kernel item for an HVM guest (non-direct kernel boot):
> 
> Xen4.0 and earlier
>   ...
>   (image
>     (hvm
>       (kernel )
>   ...
> 
> Xen4.1
>   ...
>   (image
>     (hvm
>       (kernel '')
>   ...

Thanks for the examples; that helps understand the patch.

>  
> -    if (val) {
> +    if (val && *val) {
>          *dst = strdup(val);

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111118/9a679495/attachment-0001.sig>


More information about the libvir-list mailing list