[libvirt] [PATCH] Don't copy sexpr node value that is an empty string
Jim Fehlig
jfehlig at suse.com
Fri Nov 18 23:02:22 UTC 2011
Eric Blake wrote:
> On 11/18/2011 03:16 PM, Jim Fehlig wrote:
>
>> Xen4.1 initializes some unspecified sexpr config items to an empty
>> string, unlike previous Xen versions that would leave the item unset.
>> E.g. the kernel item for an HVM guest (non-direct kernel boot):
>>
>> Xen4.0 and earlier
>> ...
>> (image
>> (hvm
>> (kernel )
>> ...
>>
>> Xen4.1
>> ...
>> (image
>> (hvm
>> (kernel '')
>> ...
>>
>
> Thanks for the examples; that helps understand the patch.
>
>
>>
>> - if (val) {
>> + if (val && *val) {
>> *dst = strdup(val);
>>
>
> ACK.
>
Thanks Eric, pushed.
Jim
More information about the libvir-list
mailing list