[libvirt] [PATCH] storage: Refetch file status after open

[Laine Stump]

On 11/25/2011 07:28 AM, Michal Privoznik wrote:
> This partly reverts my previous patch f88de3eb. We need to
> get file status after open, as given path could have been symlink,
> so fstat() will operate on different file than lstat().

Just a general note about stat/lstat/fstat - especially when working 
with image files (or anything else that could be located on a remotely 
mounted filesystem), it's best to prefer fstat over stat/lstat when 
possible, as the code will then require less modification to work 
properly when the file is not accessible by the main libvirtd process 
directly - although we don't currently do it in all necessary places, we 
("I") need to change all of those file accesses to use virFileOpenAs(), 
which forks another process to open the files, and passes the fd back to 
the caller. (In cases where it's not possible/practical to open the file 
first, we'll need to come up with some other solution).

The same holds true to opendir vs. fdopendir, but those will be a fairly 
mechanical translation anyway.