[libvirt] [PATCH 1/2] qemu: correct misspelled 'enospc' option, and only use for werror

Paolo Bonzini pbonzini at redhat.com
Wed Oct 5 11:30:26 UTC 2011


On 10/04/2011 08:35 PM, Laine Stump wrote:
> This resolves:
>
>       https://bugzilla.redhat.com/show_bug.cgi?id=730909
>
> When support for setting the qemu disk error policy to 'enospc' was
> added, it was inadvertantly as "enospace". This patch corrects that on
> the qemu commandline (while retaining the "enospace" spelling for
> libvirt's XML.
>
> Also, while examining the qemu source, I found that "enospc" is not
> allowed for the read error policy, only for write error policy (makes
> sense). Since libvirt currently only has a single error policy
> setting, when "enospace" is selected, the read error policy is set to
> "ignore".
> ---
>   src/qemu/qemu_command.c |   22 ++++++++++++++++++----
>   1 files changed, 18 insertions(+), 4 deletions(-)

For errors other than ENOSPC, werror=enospc will report the errors, so I 
believe rerror=report is a better choice.

Paolo




More information about the libvir-list mailing list