[libvirt] [PATCH] qemu: Don't fail virDomainGetInfo if we can't update balloon info

Eric Blake eblake at redhat.com
Wed Oct 5 14:22:51 UTC 2011


On 10/05/2011 08:17 AM, Jiri Denemark wrote:
> Qemu driver tries to update balloon data in virDomainGetInfo and if it
> can't do so because there is another monitor job running, it just
> reports what's known in domain def. However, if there was no job running
> but getting the data from qemu fails, we would fail the whole API. This
> doesn't make sense. Let's make the failure nonfatal.
> ---
>   src/qemu/qemu_driver.c |   13 +++++++++----
>   1 files changed, 9 insertions(+), 4 deletions(-)

ACK.  And thanks for the extra context; it made reviewing easier.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list