[libvirt] [PATCH 1/2] xen: add error handling to UUID parsing

[Guido Günther]

On Thu, Oct 06, 2011 at 04:33:49PM -0600, Eric Blake wrote:
> On 10/06/2011 11:36 AM, Guido Günther wrote:
> >>These three errors should probably all be changed away from
> >>VIR_ERR_INTERNAL_ERROR into something more useful, but I'm not sure
> >>whether that would be VIR_ERR_CONF_SYNTAX,
> >>VIR_ERR_CONFIG_UNSUPPORTED, or something else.
> >
> >I was uncertain about the error codes too, that's why I kept
> >VIR_ERR_INTERNAL_ERROR as used by other functions in this file. I'd
> >opt for VIR_ERR_CONF_SYNTAX.
> >  -- Guido
> 
> Yeah, for this particular case, where we are parsing a xen conf
> file, CONF_SYNTAX is the best fit.
> 
> >
> >>
> >>ACK to the concept, once we decide on the correct error code.
> 
> I think we've decided.
(Hopefully) final version attached. I've left the first error as
INTERNAL_ERROR since this it's there do detect false function
parameters. O.k. to apply?
Cheers,
 -- Guido
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-xen-add-error-handling-to-UUID-parsing.patch
Type: text/x-diff
Size: 2087 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111007/437a4278/attachment-0001.bin>