[libvirt] [PATCH 6/7] Rewrite all the DTrace/SystemTAP probing
Daniel P. Berrange
berrange at redhat.com
Mon Oct 10 07:59:52 UTC 2011
On Fri, Oct 07, 2011 at 12:01:18PM -0600, Eric Blake wrote:
> On 10/07/2011 09:56 AM, Daniel P. Berrange wrote:
> >+libvirt_functions.stp: $(wildcard */*.x) $(srcdir)/rpc/gensystemtap.pl
> >+ $(AM_V_GEN)perl -w $(srcdir)/rpc/gensystemtap.pl $(wildcard */*.x)> $@
>
> Does this still work in VPATH builds? If not, we may need some
> followup patches. Maybe even just $(wildcard $(srcdir)/*/*.x) is
> sufficient?
I'll check that.
>
> >+/* The double cast is necessary to silence gcc warnings; any pointer
> >+ * can safely go to intptr_t and back to void *, which collapses
> >+ * arrays into pointers; while any integer can be widened to intptr_t
> >+ * then cast to void *. */
> >+# define VIR_ADD_CASTXXXX(a) ((void *)(intptr_t)(a))
> >+# define VIR_ADD_CAST(a) (a)
>
> This doesn't quite match what used to be in libvirtd.h; in
> particular, the VIR_ADD_CASTXXXX is unused, but its body used to be
> in VIR_ADD_CAST. What's going on there? But this patch is already
> big enough that I'm okay if you commit it now, then we touch it up
> to once again fix compilation with systemtap 1.2 headers as a later
> patch.
This is a mistake. I had temporarily commented out the proper
def, for debugging something.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list