[libvirt] [PATCH] qemu: avoid text monitor null deref

Eric Blake eblake at redhat.com
Thu Oct 13 19:51:12 UTC 2011


On 10/13/2011 03:08 AM, Daniel Veillard wrote:
> On Wed, Oct 12, 2011 at 06:21:37PM -0600, Eric Blake wrote:
>> Detected by Coverity.  If, for some reason, our text monitor input
>> does not match our assumptions, we end up incrementing p while it
>> is NULL, then dereferencing the pointer 0x1, which will fault.
>>
>> * src/qemu/qemu_monitor_text.c
>> (qemuMonitorTextGetBlockStatsParamsNumber): Rewrite to avoid
>> deref of strchr failure.  Fix indentation.
>> ---

>
>    ACK,

Pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list