[libvirt] [PATCHv2] snapshot: detect when qemu lacks disk-snapshot support

[Eric Blake]

On 10/18/2011 05:31 PM, Dave Allan wrote:
> On Tue, Oct 18, 2011 at 04:04:57PM -0600, Eric Blake wrote:
>> Noticed when testing new libvirt against old qemu that lacked the
>> snapshot_blkdev HMP command.  Libvirt was mistakenly treating the
>> command as successful, and re-writing the domain XML to use the
>> just-created 0-byte file, rendering the domain broken on restart.
>>
>> * src/qemu/qemu_monitor_text.c (qemuMonitorTextDiskSnapshot):
>> Notice another possible error message.
>> * src/qemu/qemu_driver.c
>> (qemuDomainSnapshotCreateSingleDiskActive): Don't keep 0-byte file
>> on failure.
>
> ACK, snapshot still works correctly when qemu does support it, and
> after review with Eric, I think the code looks good.

Thanks; pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org