[libvirt] [PATCH] snapshot: use correct qmp monitor command

Eric Blake eblake at redhat.com
Wed Oct 19 12:57:26 UTC 2011


On 10/19/2011 03:25 AM, lvroyce wrote:
> Tested by:lvroyce
> test with cmd snapshot-create domain --disk-only ,patch works when qmp
> or hmp monitor accessible,
>
> Got trace below when issue cmd "snapshot-delete domain --snapshotname
> name",no "delvm/savevm" in qmp, only "delvm/savevm" commands in hmp.Is
> this for future compability?
>
> 2011-09-19 16:15:54.938: 25648: debug : qemuMonitorJSONIOProcessLine:115
> : Line [{"id": "libvirt-11", "error": {"class": "CommandNotFound",
> "desc": "The command delvm has not been found", "data": {"name":
> "delvm"}}}]
> 2011-09-19 16:15:54.939: 25666: debug : virJSONValueToString:1071 :
> result={"execute":"human-monitor-command","arguments":{"command-line":"delvm
> \"1319011620\""},"id":"libvirt-12"}
> 2011-09-19 16:15:54.939: 25666: debug : qemuMonitorJSONCommandWithFd:224
> : Send command
> '{"execute":"human-monitor-command","arguments":{"command-line":"delvm
> \"1319011620\""},"id":"libvirt-12"}' for write with FD -1

That's normal.  There are quite a few commands that don't exist in QMP, 
where we have to use HMP fallback.  The trace just shows that we 
attempted QMP first, but the QMP failure does not matter since the HMP 
variant worked.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list