[libvirt] [PATCH 1/1] lxc: use our own hand-rolled code in place of unlockpt and grantpt (v2)
Serge E. Hallyn
serge.hallyn at canonical.com
Wed Oct 19 20:52:36 UTC 2011
Quoting Eric Blake (eblake at redhat.com):
> >+ VIR_FORCE_CLOSE(*ttymaster);
> >+ VIR_FREE(*ttyName)
>
> How did this ever pass compile-testing without that semicolon?
It didn't. So I fixed it. Then apparently did not do a new
git format-patch before sending. Grr.
...
> ACK to the intent and to incorporating previous review comments.
> Here's what I squashed in before pushing:
Great, looks good, thanks.
-serge
More information about the libvir-list
mailing list