[libvirt] [PATCH] build: use gnulib fdatasync

Eric Blake eblake at redhat.com
Mon Oct 24 22:44:49 UTC 2011


Commit 1726a73 hacked around MacOS' lack of fdatasync, since
gnulib did not have it at the time.  But now that we use newer
gnulib, we can avoid the hack.

* bootstrap.conf (gnulib_modules): Add fdatasync.
* configure.ac (AC_CHECK_FUNCS_ONCE): Drop our own check.
---
 bootstrap.conf |    1 +
 configure.ac   |    5 +----
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index d029253..0faa2e2 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -40,6 +40,7 @@ environ
 fclose
 fcntl
 fcntl-h
+fdatasync
 ffs
 fnmatch
 fsync
diff --git a/configure.ac b/configure.ac
index df19445..6a0936a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -135,12 +135,9 @@ AC_CHECK_SIZEOF([long])

 dnl Availability of various common functions (non-fatal if missing),
 dnl and various less common threadsafe functions
-AC_CHECK_FUNCS_ONCE([cfmakeraw fdatasync geteuid getgid getgrnam_r getmntent_r \
+AC_CHECK_FUNCS_ONCE([cfmakeraw geteuid getgid getgrnam_r getmntent_r \
   getpwuid_r getuid initgroups kill mmap posix_fallocate posix_memalign \
   regexec sched_getaffinity])
-if test $ac_cv_func_fdatasync = no; then
-  AC_DEFINE([fdatasync], [fsync], [Define to fsync if you lack fdatasync])
-fi

 dnl Availability of pthread functions (if missing, win32 threading is
 dnl assumed).  Because of $LIB_PTHREAD, we cannot use AC_CHECK_FUNCS_ONCE.
-- 
1.7.4.4




More information about the libvir-list mailing list