[libvirt] [PATCH 2/2] XML: Suppress printing "domain.xml" for parse errors on XML strings

Eric Blake eblake at redhat.com
Mon Sep 5 15:02:42 UTC 2011

On 09/05/2011 06:33 AM, Peter Krempa wrote:
> Patch e81778d6184f1850a10eb661eb756b50421d5ac4 introduces printing
> file name on XML errors. This corrects the URL string to be NULL and
> therefore to print an error message not containing bogus filename
> "domain.xml".
> NULL is a valid parameter for the file name value, as the only usage is
> for error handlers. Functions touching the value either in libxml2 or in
> libvirt check this parameter for NULL and behave according to it.
> ---
>   src/conf/domain_conf.c        |    2 +-
>   src/security/virt-aa-helper.c |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

I still think a lot of the virXMLParseStringCtxt() calls in virsh.c need 
the same treatment.

Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

More information about the libvir-list mailing list