[libvirt] [PATCH 0/7] Expose QEMU APIs to Python binding

Eric Blake eblake at redhat.com
Tue Sep 13 22:44:50 UTC 2011


On 09/13/2011 03:18 AM, Daniel Veillard wrote:
>    yes but from that point on if you use inheritance, the fact of using
> the qemu tainted objects instead of the normal ones disapear completely.
> The fact of using those temporary APIs get hidden in an import and a
> new() somewhere. I would really prefer to see something explicit at the
> place where it is used, something that people can't miss where reading
> the code using it.

I like the idea of making the unsupported qemu-tainted objects explicit 
at every use point rather than hidden behind the import and new() 
hundreds of lines earlier in the file; at any rate, it means when you 
later revisit the file to clean out the unsupported qemu direct use with 
newly added libvirt features, you know every line that needs fixing. 
But I'm not enough of a python coder to know if this is typically done 
anywhere else, so I don't know if my vote counts as a tie-breaker.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list