[libvirt] [PATCH] Fix typos for snapshot-create-as in virsh help cmd and doc

Nan Zhang nzhang at redhat.com
Wed Sep 14 18:06:10 UTC 2011

* tools/virsh.c: Using VSH_OT_STRING instead of VSH_OT_ARGV for diskspec
* tools/virsh.pod: Fix missing -- tag for snapshot-create-as in docs
 tools/virsh.c   |    2 +-
 tools/virsh.pod |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index 3c6e65a..5c4610e 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -12630,7 +12630,7 @@ static const vshCmdOptDef opts_snapshot_create_as[] = {
     {"no-metadata", VSH_OT_BOOL, 0, N_("take snapshot but create no metadata")},
     {"halt", VSH_OT_BOOL, 0, N_("halt domain after snapshot is created")},
     {"disk-only", VSH_OT_BOOL, 0, N_("capture disk state but not vm state")},
-    {"diskspec", VSH_OT_ARGV, 0,
+    {"diskspec", VSH_OT_STRING, 0,
      N_("disk attributes: disk[,snapshot=type][,driver=type][,file=name]")},
     {NULL, 0, 0, NULL}
diff --git a/tools/virsh.pod b/tools/virsh.pod
index e82567d..c82cc45 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -1773,7 +1773,7 @@ by command such as B<destroy> or by internal guest action).
 =item B<snapshot-create-as> I<domain> {[I<--print-xml>]
 | [I<--no-metadata>] [I<--halt>]} [I<name>] [I<description>]
-[I<--disk-only> [I<diskspec>]...]
+[I<--disk-only>] [I<--diskspec>]...
 Create a snapshot for domain I<domain> with the given <name> and
 <description>; if either value is omitted, libvirt will choose a
@@ -1784,8 +1784,8 @@ inactive state after the snapshot is created, and if I<--disk-only>
 is specified, the snapshot will not include vm state.
 The I<--disk-only> flag is used to request a disk-only snapshot.  When
-this flag is in use, the command can also take additional I<diskspec>
-arguments to add <disk> elements to the xml.  Each <diskspec> is in the
+this flag is in use, the command can also take additional I<--diskspec>
+arguments to add <disk> elements to the xml.  Each I<--diskspec> is in the
 form B<disk[,snapshot=type][,driver=type][,file=name]>.  To include a
 literal comma in B<disk> or in B<file=name>, escape it with a second
 comma.  For example, a diskspec of "vda,snapshot=external,file=/path/to,,new"

More information about the libvir-list mailing list