[libvirt] [PATCH] Avoid using "devname" as an identifier.
Daniel Veillard
veillard at redhat.com
Fri Sep 16 12:55:44 UTC 2011
On Fri, Sep 16, 2011 at 02:05:58PM +0200, Peter Krempa wrote:
> /usr/lib/stdlib.h in Mac OS X and probably also in BSD's
> exports this symbol :(
> ---
> src/conf/domain_audit.c | 8 +++---
> src/driver.h | 2 +-
> src/libvirt.c | 12 +++++-----
> src/lxc/lxc_controller.c | 4 +-
> src/lxc/lxc_driver.c | 6 ++--
> src/network/bridge_driver.c | 14 ++++++------
> src/qemu/qemu_command.c | 28 +++++++++++++-------------
> src/qemu/qemu_driver.c | 14 ++++++------
> src/qemu/qemu_monitor.c | 36 +++++++++++++++++-----------------
> src/qemu/qemu_monitor.h | 8 +++---
> src/qemu/qemu_monitor_json.c | 26 ++++++++++++------------
> src/qemu/qemu_monitor_json.h | 8 +++---
> src/qemu/qemu_monitor_text.c | 30 ++++++++++++++--------------
> src/qemu/qemu_monitor_text.h | 8 +++---
> src/storage/storage_backend_disk.c | 14 ++++++------
> src/storage/storage_backend_mpath.c | 8 +++---
> src/uml/uml_driver.c | 8 +++---
> src/util/util.c | 6 ++--
> src/util/util.h | 2 +-
> src/xen/xen_driver.c | 6 ++--
> tools/console.c | 4 +-
> tools/console.h | 2 +-
> 22 files changed, 127 insertions(+), 127 deletions(-)
>
ACK, long but simple and I agree that using the underscore is the best
way to change the identifier, I will push it.
The thing which we could add is a small check in "make syntax-check"
to avoid adding new ones in the future.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list