[libvirt] [PATCH 1/3] build: storage: fdatasync() is not supported in Mac OS X.
veillard at redhat.com
Fri Sep 16 13:11:13 UTC 2011
On Fri, Sep 16, 2011 at 07:04:31AM -0600, Eric Blake wrote:
> On 09/16/2011 06:14 AM, Peter Krempa wrote:
> >This patch changes fdatasync() to fsync() to compile cleanly in OS X.
> I don't like this; it's too heavy-handed on working platforms.
> Rather, we should provide a gnulib wrapper function for fdatasync()
> that falls back on fsync() when compiled on MacOS. I'll get that
> done today (although for the purposes of rc3, if DV would rather
> push this patch now, and revert it later when the gnulib changes are
> complete, so that rc3 can go out before I get things done, that
> would work too).
What about a wrapper ? virFileDataSync as I sugegsted, it's still
simpler than a new gnulib function,
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list