[libvirt] [PATCH] daemon: Modify init script to check for libvirtd managed with upstart

[Daniel P. Berrange]

On Wed, Sep 21, 2011 at 12:46:33PM +0200, Peter Krempa wrote:
> On some systems init scripts are installed along with upstart . This may
> cause trouble if user tries to restart/stop a instance of libvirtd
> managed with upstart with init script.
> 
> This patch adds check for a started libvirtd managed by upstart and
> fails the init script.
> 
> [root at localhost ~]# initctl status libvirtd
> libvirtd start/running, process 3001
> [root at localhost ~]# service libvirtd restart
> Stopping libvirtd daemon: error: libvirtd is managed by upstart and
> started, use initctl instead
> 
> If libvirtd is not managed by upstart or is stopped, init script works
> normaly and allows the user to manage the service.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=728153
> ---
>  daemon/libvirtd.init.in |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)

NACK

 - Hosts should not have both the SysV initscript & upstart script
   installed at the same time

 - Even if both are installed together, there is no reason why a
   libvirtd started by upstart cannot be stopped be SysV init and
   vica-verca, since libvirtd puts its pidfile in the same place
   regardless of how it is launched


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|