[libvirt] [PATCH] locking: remove redundant codes

Eric Blake eblake at redhat.com
Thu Sep 22 01:35:15 UTC 2011


On 09/21/2011 07:15 PM, ajia at redhat.com wrote:
> From: Alex Jia<ajia at redhat.com>
>
> * src/locking/lock_driver_sanlock.c: remove redundant codes in error_unlink
>    label from virLockManagerSanlockSetupLockspace, in fact, the codes make
>    sure 'path' is non-null before getting to error_unlink label, so 'if (path)'
>    is redundant, removing it in here and will also silence coverity.

I'd rather go with my more comprehensive patch, since it also fixes a 
mem leak:
https://www.redhat.com/archives/libvir-list/2011-September/msg00865.html

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list