[libvirt] [PATCH v2] qemu: add return value check

Eric Blake eblake at redhat.com
Wed Sep 28 17:10:31 UTC 2011


On 09/28/2011 02:00 AM, ajia at redhat.com wrote:
> From: Alex Jia<ajia at redhat.com>
>
> * src/qemu/qemu_migration.c: if 'vmdef' is NULL, the function
>    virDomainSaveConfig still dereferences it, it doesn't make
>    sense, so should add return value check to make sure 'vmdef'
>    is non-NULL before calling virDomainSaveConfig, in addition,
>    in order to debug later, also should record error information
>    into log.
>
> Signed-off-by: Alex Jia<ajia at redhat.com>
> ---
>   src/qemu/qemu_migration.c |    5 ++++-
>   1 files changed, 4 insertions(+), 1 deletions(-)

ACK and pushed, after fixing your trailing whitespace bug that 'make 
syntax-check' tripped on.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list