[libvirt] [PATCH v2 1/4] api: Add public api for 'reset'

[Xu He Jie]

Thanks a lot!

On 2011年09月29日 20:52, Eric Blake wrote:
> On 09/29/2011 02:53 AM, Xu He Jie wrote:
>> Add new public api for 'reset'.
>> It can reset domain immediately without any guest shutdown.
>>
>
>>
>> /**
>> + * virDomainReset:
>> + * @domain: a domain object
>> + * @flags: extra flags for the reboot operation, not used yet
>> + *
>> + * Reset a domain immediately without any guest OS shutdown.
>> + * Reset emulates the power reset of a button on a machine, i.e.
>> + * All hardware see the RST line set and reinitialize their internal 
>> state.
>> + *
>> + * Note that the risk of data loss caused by reset without any
>> + * guest OS shutdown.
>
> I made some grammar tweaks.
>
>> +++ b/src/libvirt_public.syms
>> @@ -492,6 +492,7 @@ LIBVIRT_0.9.5 {
>> LIBVIRT_0.9.7 {
>> global:
>> virDomainSnapshotGetParent;
>> + virDomainReset;
>
> Also, I sorted these. I'll squash this in and push shortly.
>
> diff --git i/src/libvirt.c w/src/libvirt.c
> index 7fcbda4..9080b2f 100644
> --- i/src/libvirt.c
> +++ w/src/libvirt.c
> @@ -3022,10 +3022,10 @@ error:
> * @flags: extra flags for the reboot operation, not used yet
> *
> * Reset a domain immediately without any guest OS shutdown.
> - * Reset emulates the power reset of a button on a machine, i.e.
> - * All hardware see the RST line set and reinitialize their internal 
> state.
> + * Reset emulates the power reset button on a machine, where all
> + * hardware sees the RST line set and reinitializes internal state.
> *
> - * Note that the risk of data loss caused by reset without any
> + * Note that there is a risk of data loss caused by reset without any
> * guest OS shutdown.
> *
> * Returns 0 in case of success and -1 in case of failure.
> diff --git i/src/libvirt_public.syms w/src/libvirt_public.syms
> index 9e6f104..afea29b 100644
> --- i/src/libvirt_public.syms
> +++ w/src/libvirt_public.syms
> @@ -491,8 +491,8 @@ LIBVIRT_0.9.5 {
>
> LIBVIRT_0.9.7 {
> global:
> - virDomainSnapshotGetParent;
> virDomainReset;
> + virDomainSnapshotGetParent;
> } LIBVIRT_0.9.5;
>
> # .... define new API here using predicted next version number ....
>