[libvirt] [PATCH 2.6/4] snapshot: virsh fallback for snapshot-list --from children

Eric Blake eblake at redhat.com
Fri Sep 30 23:05:19 UTC 2011


On 09/29/2011 04:02 PM, Eric Blake wrote:
> Iterating over one level of children requires parsing all snapshots
> and their parents; a bit of code shuffling makes it pretty easy
> to do this as well.
>
> * tools/virsh.c (cmdSnapshotList): Add another fallback.
> ---
>
> Applies anywhere after 2.5/4, but again, easiest to test against the
> same version of libvirtd if applied before 3/4.
>

> +        if (numsnaps<  0) {
> +            /* XXX also want to emulate --descendants without --tree */
> +            if ((!descendants || tree)
> +                last_error->code == VIR_ERR_NO_SUPPORT) {

This doesn't even compile.  Let me send a cleaned up v2.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list