[libvirt] question on API spelling
Martin Kletzander
mkletzan at redhat.com
Tue Apr 3 09:10:46 UTC 2012
On 04/03/2012 01:05 AM, Eric Blake wrote:
> We're quite inconsistent on US (canceled) vs. UK (cancelled) spelling in
> our public API:
>
> include/libvirt/libvirt.h.in:124:
> VIR_DOMAIN_RUNNING_MIGRATION_CANCELED = 6, /* returned from migration */
> include/libvirt/libvirt.h.in:125: VIR_DOMAIN_RUNNING_SAVE_CANCELED =
> 7, /* returned from failed save process */
> include/libvirt/libvirt.h.in:3220: VIR_DOMAIN_JOB_CANCELLED = 5, /*
> Job was aborted, but isn't cleaned up */
> include/libvirt/virterror.h:247:
> canceled/aborted by user */
> include/libvirt/virterror.h:248: VIR_ERR_AUTH_CANCELLED = 79,
> /* authentication cancelled */
>
> Is it worth adding aliases so that a programmer can use consistent spelling?
>
I think it's worth it, because it looks pretty bad like this.
I just wonder if it could confuse someone, but that's probably too
paranoid idea :)
Martin
More information about the libvir-list
mailing list