[libvirt] [PATCH 3/3] Fix parallel build in docs/ directory
Jiri Denemark
jdenemar at redhat.com
Wed Apr 4 13:04:27 UTC 2012
On Wed, Apr 04, 2012 at 13:47:59 +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> Every now & then, with parallel builds, we get a failure to
> validate hvsupport.html.in. I eventually noticed that this
> is because we get 2 instances of the generator running at
> once.
>
> We already list hvsupport.html.in in BUILT_SOURCES but this
> was not working. It turns out the flaw is that we were
> adding deps to the 'all:' target instead of the 'all-am:'
> target. BUILT_SOURCES is a dep of 'all', so any custom
> targets written in Makefile.am must use 'all-am:' so that
> they don't get run until BUILT_SOURCES are completely
> generated
>
> * docs/Makefile.am: s/all/all-am/
> ---
> docs/Makefile.am | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/docs/Makefile.am b/docs/Makefile.am
> index 2bef982..53328f7 100644
> --- a/docs/Makefile.am
> +++ b/docs/Makefile.am
> @@ -116,7 +116,7 @@ MAINTAINERCLEANFILES = \
> $(addprefix $(srcdir)/,$(apihtml)) \
> $(addprefix $(srcdir)/,$(devhelphtml))
>
> -all: web
> +all-am: web
>
> api: $(srcdir)/libvirt-api.xml $(srcdir)/libvirt-refs.xml
> qemu_api: $(srcdir)/libvirt-qemu-api.xml $(srcdir)/libvirt-qemu-refs.xml
Oh, cool. I saw this several times myself and I was wondering why it happened
since everything looked correct at first glance. Thanks for fixing it. ACK.
Jirka
More information about the libvir-list
mailing list