[libvirt] [PATCH 2/4] Add API for loading daemon config from in-memory blob
Eric Blake
eblake at redhat.com
Fri Apr 6 16:58:08 UTC 2012
On 04/04/2012 08:07 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> ---
Sparse on the commit message; even mentioning the name of the new API
will help a later 'git log' search for the introduction of the new name.
> daemon/libvirtd-config.c | 67 +++++++++++++++++++++++++++++++--------------
> daemon/libvirtd-config.h | 9 ++++--
> daemon/libvirtd.c | 2 +-
> 3 files changed, 53 insertions(+), 25 deletions(-)
>
> -
> - conf = virConfReadFile (filename, 0);
Bad style (space in function call) here...
>
> - virConfFree (conf);
> return 0;
>
> error:
> - virConfFree (conf);
and here...
> +
> + conf = virConfReadFile(filename, 0);
but while you fixed it here...
> + if (!conf)
> + return -1;
> +
> + ret = daemonConfigLoadOptions(data, filename, conf);
> + virConfFree (conf);
...you missed here.
ACK with that nit fixed.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120406/2ffd78b6/attachment-0001.sig>
More information about the libvir-list
mailing list