[libvirt] [PATCH] Fix compilation error on 32bit

Stefan Berger stefanb at linux.vnet.ibm.com
Fri Apr 6 19:13:20 UTC 2012


Below code failed to compile on a 32 bit machine with error

typewrappers.c: In function 'libvirt_intUnwrap':
typewrappers.c:135:5: error: logical 'and' of mutually exclusive tests 
is always false [-Werror=logical-op]
cc1: all warnings being treated as errors

The patch fixes this error.

   Stefan

---
  python/typewrappers.c |    4 ++++
  1 file changed, 4 insertions(+)

Index: libvirt-acl/python/typewrappers.c
===================================================================
--- libvirt-acl.orig/python/typewrappers.c
+++ libvirt-acl/python/typewrappers.c
@@ -132,6 +132,7 @@ libvirt_intUnwrap(PyObject *obj, int *va
      if ((long_val == -1) && PyErr_Occurred())
          return -1;

+#if LONG_MAX != INT_MAX
      if (long_val >= INT_MIN && long_val <= INT_MAX) {
          *val = long_val;
      } else {
@@ -139,6 +140,9 @@ libvirt_intUnwrap(PyObject *obj, int *va
                          "Python int too large to convert to C int");
          return -1;
      }
+#else
+    *val = long_val;
+#endif
      return 0;
  }




More information about the libvir-list mailing list