[libvirt] [test-API PATCH 0/4]Add feature to check case file before running

Guannan Ren gren at redhat.com
Thu Apr 12 17:03:40 UTC 2012


On 04/12/2012 09:43 PM, Guannan Ren wrote:
> On 04/12/2012 07:53 PM, Peter Krempa wrote:
>> I don't think pushing this series without a review was a good idea. 
>> You actualy broke all of the tests in the repos/ as you didn't do the 
>> modifications to the parameter checking algorithm in a way that 
>> didn't require modification of the tests, neither did you change the 
>> tests to cope with the new code. The result is now:
>>
>> exception.TestCaseError: 'required_params or optional_params not 
>> found in interface:destroy'
>>
>> or similar for every test case.
>>
>> Peter
>
>
>     Yes, sorry about this.
>     There is some new feature and cleanup work on my hand, I don't know
>     the exact time to get review.
>     The error is generated by framework.  the part job of framework is 
> done.
>     The cleanup work on testcase is ongoing,  I am sure that I will 
> finish the work today.
>

         The cleanup is done and pushed.
         I only wan to send framework code here, the cleaning code in 
testcases is huge
         and mechanical, maybe nobody likes seeing it :)
         Sorry about the intact commit again.

         Guannan Ren




More information about the libvir-list mailing list