[libvirt] [test-API 0/3] Destroy class for utils/check.py

Osier Yang jyang at redhat.com
Wed Apr 18 07:14:55 UTC 2012


On 2012年04月18日 15:07, Guannan Ren wrote:
> On 04/17/2012 09:44 PM, Osier Yang wrote:
>> Just as what we did for utils/utils.py, we don't benifit
>> from the class use at all.
>>
>> Osier Yang (3):
>> remove importing of unused check module
>> Destroy class of utils/check.py
>> Destroy use of check class
>>
>> repos/domain/balloon_memory.py | 3 +-
>> repos/domain/dump.py | 4 +-
>> repos/domain/install_linux_check.py | 15 +-
>> repos/snapshot/file_flag.py | 7 +-
>> repos/snapshot/flag_check.py | 3 +-
>> utils/check.py | 649 +++++++++++++++++------------------
>> utils/xmlgenerator.py | 1 -
>> 7 files changed, 335 insertions(+), 347 deletions(-)
>>
>
> I don't need the check.py anymore, it should be depreciated.
> It works as the utils.py more or less, we probably need to remove it.
> and move the valuable function into utils.py

That was in my TOTO list, really no need to have a standalone
check.py, useful functions should be in utils.py.

>
> ACK with these changes, but need to remove the file later.
>
> Guannan Ren
>

Thanks, Pushed the set.

Osier




More information about the libvir-list mailing list