[libvirt] [PATCH] Remove the useless scripts directory and script under it

Guannan Ren gren at redhat.com
Wed Apr 18 07:29:30 UTC 2012


On 04/18/2012 03:18 PM, Osier Yang wrote:
> On 2012年04月18日 15:12, Guannan Ren wrote:
>> On 04/17/2012 10:19 PM, Osier Yang wrote:
>>> The script is useful only if all the scripts have good document
>>> comments. Unfortunately, it's not true, and it's burden for
>>> developers to write those documents in specific format somehow,
>>> on the other hand, because we introduced required_opts, optional_opts
>>> for each cases to generate the usage strings, and new option "-t"
>>> to print template for cases, it's no need to write documents
>>> in specific format for scripts now.
>>> ---
>>> scripts/gen_case_doc.sh | 21 ---------------------
>>> 1 files changed, 0 insertions(+), 21 deletions(-)
>>> delete mode 100644 scripts/gen_case_doc.sh
>>>
>>> diff --git a/scripts/gen_case_doc.sh b/scripts/gen_case_doc.sh
>>> deleted file mode 100644
>>> index e814532..0000000
>>> --- a/scripts/gen_case_doc.sh
>>> +++ /dev/null
>>> @@ -1,21 +0,0 @@
>>> -#! /bin/sh
>>> -# Create documentation of cases in Python
>>> -
>>> -FILES=`find $PWD/repos/Python -type f -name "*.py"`
>>> -
>>> -for i in ${FILES}; do
>>> - if [ $(basename $i) != '__init__.py' ]; then
>>> - DIRNAME=$(dirname $i)
>>> - DIRNAME=$(echo $DIRNAME | sed -e 's:repos:doc:g')
>>> - fi
>>> -
>>> - if ! [ -e $DIRNAME ]; then
>>> - mkdir -p $DIRNAME
>>> - fi
>>> -
>>> - cd $DIRNAME
>>> - pydoc -w $i
>>> - cd -
>>> -done
>>> -
>>> -exit $?
>>
>> ACK
>> I assume that the folder has been removed together.
>>
>
> Thanks, pushed. The directory can be left, or remove,
> either is fine, as there is follow up patch to move
> install-autostart-server to scripts.
>
> Osier
>

     The install-autostart-server is in autotest upstream,
     and it has nothing to do with test-API, we need find another
     place for it. not this repo, so better to remove
     the empty folder as well as the script I think.




More information about the libvir-list mailing list