[libvirt] [test-API 12/17] Substitute 'guest"' with 'domain"'

Peter Krempa pkrempa at redhat.com
Mon Apr 23 07:40:31 UTC 2012


On 04/20/2012 08:46 AM, Osier Yang wrote:
> % for i in $(grep 'guest"' * -r | awk -F':' '{print $1}'| uniq); do \
>      sed -i -e 's/guest"/domain"/g' $i; \
>    done
>
> This also affects the codes like:
>
> -    url = global_parser.get_value("guest", gname + "src")
> -    dict['kickstart'] = global_parser.get_value("guest", gname + "ks")
> +    url = global_parser.get_value("domain", gname + "src")
> +    dict['kickstart'] = global_parser.get_value("domain", gname + "ks")
>
> A follow up patch will change the property 'guest' into 'domain'
> ---

I don't like this very much. "Domain" is a XEN term. IMHO "guest" is 
more universal and is a little more specific. (It's harder to 
distinguish Xen's Dom0 vs DomU than "host" and "guest")

Peter




More information about the libvir-list mailing list