[libvirt] [PATCH v10 9/9] parallels: implement VM creation

Alex Jia ajia at redhat.com
Fri Aug 3 10:52:19 UTC 2012


On 08/01/2012 10:51 PM, Eric Blake wrote:
> On 07/31/2012 09:34 PM, Daniel Veillard wrote:
>> On Tue, Jul 31, 2012 at 10:56:13PM +0400, Dmitry Guryanov wrote:
>>> To create a new VM in Parallels Clud Server we should issue

s/Clud/Cloud/ ?

>>> "prlctl create" command, and give path to the directory,
>>> where VM should be created. VM's storage will be in that
>>> directory later. So in this first version find out location
>>> of first VM's hard disk and create VM there.
>>>
>>    as well as this one led to 'make syntax-check errors', I squashed in
>>    the following which looks a safe way to try to provide informations,
>>
>> Daniel
>>
>> diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
>> index e1bc83e..b57ac96 100644
>> --- a/src/parallels/parallels_driver.c
>> +++ b/src/parallels/parallels_driver.c
>> @@ -1568,7 +1568,8 @@ parallelsCreateVm(virConnectPtr conn, virDomainDefPtr def)
>>            * let's report error if no disk until better solution
>>            * will be found */
>>           virReportError(VIR_ERR_INVALID_ARG,
>> -                       _("Can't create VM without hard disks"));
>> +                       _("Can't create VM '%s' without hard disks"),
>> +                       (def->name ? def->name : "no name"));
> This doesn't translate well.  Perhaps
>
> s/"no name"/_("(unnamed)")/
>
> would be better.
>
>
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120803/15b178f3/attachment-0001.htm>


More information about the libvir-list mailing list