[libvirt] [PATCH] Don't check the 'connect' command in virsh-all test

Eric Blake eblake at redhat.com
Tue Aug 7 13:51:21 UTC 2012


On 08/07/2012 05:03 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> The 'virsh-all' test case will invoke each virsh command with
> no args. With the 'connect' command this causes virsh to try
> to connect to the default URI, which in turn tries to spawn
> libvirtd. This is not something we want todo in the test suite,
> so skip the 'connect' command.
> ---
>  tests/virsh-all |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

ACK.  I've mentioned the issue before, and even wondered whether it
would make sense to alter the semantics of the 'connect' command with no
arguments to instead reconnect to the current URI instead of
reconnecting to the default URI, but never got around to polishing a
patch into something I like.  So this is a decent compromise of just
avoiding the problem altogether.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120807/752af4d9/attachment-0001.sig>


More information about the libvir-list mailing list