[libvirt] [PATCH 4/8] Fix error reporting in virSecuritySELinuxGenNewContext

Eric Blake eblake at redhat.com
Fri Aug 10 17:48:05 UTC 2012


On 08/10/2012 07:47 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> The virSecuritySELinuxGenNewContext method was not reporting any
> errors, leaving it upto the caller to report a generic error.

s/upto/up to/

> In addition it could potentially trigger a strdup(NULL) in an
> OOM scenario. Move all error porting into the

s/porting/reporting/

> virSecuritySELinuxGenNewContext method where accurate info
> can be provided
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/security/security_selinux.c | 67 +++++++++++++++++++++++------------------
>  1 file changed, 37 insertions(+), 30 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120810/a6336604/attachment-0001.sig>


More information about the libvir-list mailing list