[libvirt] [PATCH v4] json: fix interface locale dependency
Martin Kletzander
mkletzan at redhat.com
Tue Aug 14 05:31:07 UTC 2012
On 08/13/2012 07:27 PM, Eric Blake wrote:
> On 08/13/2012 10:02 AM, Martin Kletzander wrote:
>> libvirt creates invalid commands if wrong locale is selected. For
>> example with locale that uses comma as a decimal point, JSON commands
>> created with decimal numbers are invalid because comma separates the
>> entries in JSON. Fortunately even when decimal point is affected,
>> thousands grouping is not, because for grouping to be enabled with
>> *printf, there has to be an apostrophe flag specified (and supported).
>>
>> This patch adds specific internal function for converting doubles to
>> strings with C locale.
>> --
>> v4:
>> - changed according to Eric's suggestions
>> ---
>> bootstrap.conf | 1 +
>> configure.ac | 4 +-
>> src/libvirt_private.syms | 1 +
>> src/util/json.c | 2 +-
>> src/util/util.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++
>> src/util/util.h | 3 ++
>> 6 files changed, 71 insertions(+), 3 deletions(-)
>
> ACK
>
Thanks, pushed.
Martin
More information about the libvir-list
mailing list