[libvirt] [PATCHv2 3/9] util: add openvswitch case to virNetDevVPortProfileEqual

Kyle Mestery (kmestery) kmestery at cisco.com
Tue Aug 14 13:21:56 UTC 2012


This looks good to me.

Acked-by: Kyle Mestery <kmestery at cisco.com>

On Aug 14, 2012, at 2:04 AM, Laine Stump wrote:

> This function was overlooked when openvswitch support was
> added. Fortunately it's only use for update-device, which is
> relatively new and seldom-used.
> ---
> src/util/virnetdevvportprofile.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/src/util/virnetdevvportprofile.c b/src/util/virnetdevvportprofile.c
> index af9151e..6db04f7 100644
> --- a/src/util/virnetdevvportprofile.c
> +++ b/src/util/virnetdevvportprofile.c
> @@ -107,6 +107,12 @@ virNetDevVPortProfileEqual(virNetDevVPortProfilePtr a, virNetDevVPortProfilePtr
>             return false;
>         break;
> 
> +    case VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH:
> +        if (STRNEQ(a->profileID, b->profileID) ||
> +            memcmp(a->interfaceID, b->interfaceID, VIR_UUID_BUFLEN) != 0)
> +            return false;
> +        break;
> +
>     default:
>         break;
>     }
> -- 
> 1.7.11.2
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list





More information about the libvir-list mailing list