[libvirt] [PATCH] maint: prohibit translations in testsuite

Eric Blake eblake at redhat.com
Mon Aug 20 14:30:07 UTC 2012


Nothing in the testsuite or examples directory should be translated,
as it is not part of the normally installed binary.  We already
meet this rule, but enforcing it will make it easier to remember.

Suggested by Daniel P. Berrange.

* cfg.mk (sc_prohibit_useless_translation): Enhance rule.
---
 cfg.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/cfg.mk b/cfg.mk
index 224f89f..4fd3165 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -587,10 +587,15 @@ sc_prohibit_diagnostic_without_format:
 	    exit 1; } || :

 # The strings "" and "%s" should never be marked for translation.
+# Files under tests/ and examples/ should not be translated.
 sc_prohibit_useless_translation:
 	@prohibit='_\("(%s)?"\)'					\
 	halt='$(ME): found useless translation'				\
 	  $(_sc_search_regexp)
+	@prohibit='\<N?_ *\('						\
+	in_vc_files='^(tests|examples)/'				\
+	halt='$(ME): no translations in tests or examples'		\
+	  $(_sc_search_regexp)

 # Enforce recommended preprocessor indentation style.
 sc_preprocessor_indentation:
-- 
1.7.11.4




More information about the libvir-list mailing list