[libvirt] [PATCH v2.1 01/21] Introduce the function virCgroupForEmulator

[Daniel P. Berrange]

On Tue, Aug 21, 2012 at 05:18:24PM +0800, Hu Tao wrote:
> From: Wen Congyang <wency at cn.fujitsu.com>
> 
> Introduce the function virCgroupForEmulator() to create sub directory
> for simulator thread(include I/O thread, vhost-net thread)
> 
> Signed-off-by: Wen Congyang <wency at cn.fujitsu.com>
> Signed-off-by: Tang Chen <tangchen at cn.fujitsu.com>
> Signed-off-by: Hu Tao <hutao at cn.fujitsu.com>
> ---
>  src/libvirt_private.syms |    1 +
>  src/util/cgroup.c        |   42 ++++++++++++++++++++++++++++++++++++++++++
>  src/util/cgroup.h        |    4 ++++
>  3 files changed, 47 insertions(+)
> 
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index a55fb73..6e834fe 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -71,6 +71,7 @@ virCgroupDenyDeviceMajor;
>  virCgroupDenyDevicePath;
>  virCgroupForDomain;
>  virCgroupForDriver;
> +virCgroupForEmulator;
>  virCgroupForVcpu;
>  virCgroupFree;
>  virCgroupGetBlkioWeight;
> diff --git a/src/util/cgroup.c b/src/util/cgroup.c
> index 2256c23..169b56a 100644
> --- a/src/util/cgroup.c
> +++ b/src/util/cgroup.c
> @@ -957,6 +957,48 @@ int virCgroupForVcpu(virCgroupPtr driver ATTRIBUTE_UNUSED,
>  #endif
>  
>  /**
> + * virCgroupForEmulator:
> + *
> + * @driver: group for the domain
> + * @group: Pointer to returned virCgroupPtr
> + *
> + * Returns: 0 on success or -errno on failure
> + */
> +#if defined HAVE_MNTENT_H && defined HAVE_GETMNTENT_R
> +int virCgroupForEmulator(virCgroupPtr driver,
> +                          virCgroupPtr *group,
> +                          int create)

We should s/int create/bool create/ throughout the cgroups.[ch] files,
but I'll ACK your patch anyway, since you're just following existing
practice in this file. If you want to send a followup patch later to
switch cgroups.c to use 'bool create' everywhere that'd be useful.

> +{
> +    int rc;
> +    char *path;
> +
> +    if (driver == NULL)
> +        return -EINVAL;
> +
> +    if (virAsprintf(&path, "%s/emulator", driver->path) < 0)
> +        return -ENOMEM;
> +
> +    rc = virCgroupNew(path, group);
> +    VIR_FREE(path);
> +
> +    if (rc == 0) {
> +        rc = virCgroupMakeGroup(driver, *group, create, VIR_CGROUP_VCPU);
> +        if (rc != 0)
> +            virCgroupFree(group);
> +    }
> +
> +    return rc;
> +}
> +#else
> +int virCgroupForEmulator(virCgroupPtr driver ATTRIBUTE_UNUSED,
> +                          virCgroupPtr *group ATTRIBUTE_UNUSED,
> +                          int create ATTRIBUTE_UNUSED)
> +{
> +    return -ENXIO;
> +}
> +
> +#endif
> +/**
>   * virCgroupSetBlkioWeight:
>   *
>   * @group: The cgroup to change io weight for
> diff --git a/src/util/cgroup.h b/src/util/cgroup.h
> index 265f7c9..9f803a5 100644
> --- a/src/util/cgroup.h
> +++ b/src/util/cgroup.h
> @@ -59,6 +59,10 @@ int virCgroupForVcpu(virCgroupPtr driver,
>                       virCgroupPtr *group,
>                       int create);
>  
> +int virCgroupForEmulator(virCgroupPtr driver,
> +                         virCgroupPtr *group,
> +                         int create);
> +
>  int virCgroupPathOfController(virCgroupPtr group,
>                                int controller,
>                                const char *key,

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|