[libvirt] [PATCH] additional parameter needed for dnsmasq

[Claudio Bley]

At Wed, 22 Aug 2012 10:23:44 -0400,
Gene Czarcinski wrote:
> Second, I have since the rpm will compile with my patch and goes
> through enough of -bi --short-circuit to create
> BUILDROOT/libvirt.../usr/sbin/libvirtd I am copying this over to a
> real system and installing it replacing the original
> /usr/sbin/libvirtd
> 
> With my patch installed, when libvirtd attempts to start a network, it
> errors out with something like the follow:
> ====================
> internal error Child process (/sbin/dnsmasq --strict-order
> --bind-interfaces --domain virt123 --local=/virt123/ --domain-needed
> --filterwin2k --pid-file=/var/run/libvirt/network/net123.pid
> --conf-file= --except-interface lo --listen-address 192.168.123.1
> --dhcp-range 192.168.123.128,192.168.123.254
> --dhcp-leasefile=/var/lib/libvirt/dnsmasq/net123.leases
> --dhcp-lease-max=127 --dhcp-no-override --expand-hosts) status
> unexpected: exit status 1
> ====================
> 
> >>> +    virCommandAddArgFormat(cmd,
> >>> +                "--domain %s --local=/%s/",
> >>> +                network->def->domain,
> >>> +                network->def->domain);

Here, you're adding "--domain D --local=/D/" as a *single* argument to
the dnsmasq call.

You need to provide "--domain", network->def->domain, "--local=/D/" as
3 arguments to the call, ie. first use
virCommandAddArgPair(cmd, "--domain", D), then use virCommandAddArgFormat
for the --local part.

Claudio
-- 
AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany
Phone: +49 341 265 310 19
Web:<http://www.av-test.org>

Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076)
Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern