[libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2

[Jim Fehlig]

Doug Goldstein wrote:
> On Mon, Aug 27, 2012 at 4:57 AM, Justin Clift <jclift at redhat.com> wrote:
>   
>> On 27/08/2012, at 1:00 PM, Daniel Veillard wrote:
>>     
>>>  I tagged the rc2 in the git tree and pushed tarball and rpms to
>>> the usual place:
>>>  ftp://libvirt.org/libvirt/
>>>
>>> it should include the various fixes that were made on top of rc1
>>> and fix the compilation problem exposed on OS-X, as well as picking
>>> libnl3 if available,
>>>
>>>  please give it a try and report, I am still shooting for a final
>>> release this Wednesday,
>>>       
>> Still a no go on OSX.  Different error this time:
>>
>>   ...
>>   libvirtd.c: In function 'main':
>>   libvirtd.c:1316: error: 'NETLINK_ROUTE' undeclared (first use in this function)
>>   libvirtd.c:1316: error: (Each undeclared identifier is reported only once
>>   libvirtd.c:1316: error: for each function it appears in.)
>>   libvirtd.c:1322: error: 'NETLINK_KOBJECT_UEVENT' undeclared (first use in this function)
>>   make[3]: *** [libvirtd-libvirtd.o] Error 1
>>   make[3]: *** Waiting for unfinished jobs....
>>     

I'm seeing the same issue building on an older SLES where HAVE_LIBNL is
not defined.

>> Any ideas?
>>
>> + Justin
>>
>>     
>
> You can try something like the following to get you a little farther
> and see if it fails farther on. Just trying to see if we can get Mac
> OS X built and see what changes need to happen before 0.10.0 goes out
> final, not necessary "proper" patches just yet.
>
> diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h
> index 1982dae..c3f3e81 100644
> --- a/src/util/virnetlink.h
> +++ b/src/util/virnetlink.h
> @@ -34,6 +34,9 @@ struct nl_msg;
>  struct sockaddr_nl;
>  struct nlattr;
>
> +#define NETLINK_ROUTE       0   /* Routing/device hook              */
> +#define NETLINK_KOBJECT_UEVENT  15  /* Kernel messages to userspace */
> +
>  # endif /* __linux__ */
>
>  int virNetlinkStartup(void);
>   

This workaround fixed the build.  Is this an acceptable fix, or should
commits 080bf330 and d5756794 have conditionally called
virNetlinkEventServiceStart(...) based on HAVE_LIBNL?

Regards,
Jim