[libvirt] [PATCH] qemu: Add quotes to kernel command line of direct kernel boot

Zhou Zheng Sheng zhshzhou at linux.vnet.ibm.com
Tue Aug 28 02:05:00 UTC 2012


When passing kernel command line arguments, it is possible to have
spaces. The arguments should be protected in qoutes.

In http://libvirt.org/formatdomain.html "direct kernel boot" section,
there is an example.
   ...
   <os>
     <type>hvm</type>
     <loader>/usr/lib/xen/boot/hvmloader</loader>
     <kernel>/root/f8-i386-vmlinuz</kernel>
     <initrd>/root/f8-i386-initrd</initrd>
     <cmdline>console=ttyS0 ks=http://example.com/f8-i386/os/</cmdline>
   </os>
   ...
If the contents in <cmdline> are passed as-is to qemu, then qemu will see
   qemu ... -append console=ttyS0 ks=http://example.com/f8-i386/os/ ...
It must be quoted, so let qemu see
   qemu ... -append "console=ttyS0 ks=http://example.com/f8-i386/os/" ...

Signed-off-by: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
---
  src/qemu/qemu_command.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-quotes-to-kernel-command-line-of-direct-kernel-b.patch
Type: text/x-patch
Size: 607 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120828/462d77c6/attachment-0001.bin>


More information about the libvir-list mailing list