[libvirt] RFC: APIs to manage KSM

[Eric Blake]

On 08/31/2012 07:46 AM, Daniel P. Berrange wrote:
> On Fri, Aug 31, 2012 at 04:56:01PM +0800, Osier Yang wrote:
>> Triggered by the requirement to control the new sys knob
>> /sys/kernel/mm/ksm/merge_nodes for a NUMA aware host by
>> patch:
>>

> 
> As a general point, we should not use the term 'KSM' in the API
> names, since that is an implementation specific name. We want
> some more generic name. eg
> 
>   virNodeSetMemorySharingParameters
> 
> likewise for all the enum/constant names.

For that matter, why can't we reuse the existing
virDomainSetMemoryParameters() for the enum/constants?  That is, whether
or not to use ksm is a memory parameter.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120831/8629ce60/attachment-0001.sig>